CleverRaven/Cataclysm-DDA

Taking away bandages from friendly NPC followers bug

Open

#66,017 opened on Jun 5, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
<Crash / Freeze>Help Wanted

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

Taking away bandages from friendly NPC followers while they are bandaging themselves will cause the game to crash.

Attach save file

N/A

Steps to reproduce

  1. Give the friendly NPC some bandages and antiseptic
  2. Make the friendly take damage from zombies
  3. The NPC will proceed to bandage himself ( might require the npc to have a bit of healthcare skill, the friendly NPC that triggered this bug had 8 in healthcare )
  4. Kill zombie (optional)
  5. Take away those bandages and antiseptics BEFORE the NPC finishes using "first aid "
  6. Walk around a bit
  7. Game crash

Expected behavior

I expected the the NPC to stop applying first aid and go on as normal

Screenshots

Seconds before the crash. image What pops up after the crash image

Versions and configuration

Windows 10 Using the latest Stable 0.G Gaiman Using the Built in MSXOTTO tileset

Additional context

crash.log debug.log

Contributor guide

Research direction
Examine the NPC first aid action code and item removal handling. Trace the use of items during NPC healing to identify where a null pointer or use after free occurs when items are taken away mid action.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Game development debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40