CleverRaven/Cataclysm-DDA

Hobby basement overrides a chunk of the actual basement

Open

#65,933 opened on May 30, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedMap / Mapgen[JSON]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

When going into basements, while not clearly evident, there are some times where basements have randomly walled off components, probably due to the hobby basements.

Attach save file

N/A

Steps to reproduce

  1. go to basement of house, check to find discrepancy between first floor and basement
  2. check by teleporting in areas where it seemingly lacks
  3. find randomly walled off basements

Expected behavior

The basement should properly utilize these spaces.

Screenshots

buggy hobby basement

Versions and configuration

  • OS: Windows 10
  • Version ddd274c
  • Ingame Lang: English
  • Mods: Basegame

Additional context

This could be solved by either finding a way for hobby basement to utilize all the extra space, or by simply having the hobby basement delete the extra space. Either way sounds like it would work.

Contributor guide

Research direction
Investigate the hobby basement generation code and identify how it overlaps with the main basement. Look for tile placement logic that might block areas.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50