CleverRaven/Cataclysm-DDA

NPCs still occasionally preferring non weapon weapons for combat

Open

#65,776 opened on May 21, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedNPC / Factions[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

NPCs will still randomly drop their gun or melee weapon and pick up a leather belt or helmet to attack with.

After a escaping a group of bandits last night because two of them dropped weapons to use their belt and helmet I wonder if https://github.com/cataclysmbnteam/Cataclysm-BN/pull/2773 and it's precursor would improve weapon NPC weapon selection but it's probably beyond me to apply these changes. Hopefully someone else is able to look into this.

Attach save file

N/A

Steps to reproduce

Meet a group of bandits, watch in awe as half of them go from weapons to random objects as weapons.

Expected behavior

NPCs to use at least a decent weapon even if they don't always use the best weapon for any given situation.

Screenshots

No response

Versions and configuration

Current

Additional context

No response

Contributor guide

Research direction
Investigate the NPC weapon selection logic in the combat code. Look for where NPCs decide to pick up items and why they might choose non weapons. Trace the code path that evaluates item value for combat. Consider the changes in referenced PR #2773 and apply similar logic to improve selection.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70