CleverRaven/Cataclysm-DDA

Light do not respect 3D FoV

Open

#65,514 opened on May 6, 2023

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedZ-levels[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

If you try to use lighter at night, only your z-level would be illuminated

Attach save file

N/A

Steps to reproduce

  1. Set time to 23:00
  2. Teleport to any roof or z-level 1
  3. Use flashlight
  4. See nothing above and under your character is illuminated

Expected behavior

Being able to see stuff below

Screenshots

GIF 06-05-2023 20-00-17

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2846 (21H2)
  • Game Version: bbfa357 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions], Magiclysm [magiclysm], Xedra Evolved [xedra_evolved], Mythical Martial Arts [MMA] ]

Additional context

No response

Contributor guide

Research direction
Examine the field of view calculation logic during night time, specifically how light sources interact with z levels. Check the light radius function and ensure it applies to all z levels within range.
Tech stack
None
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65