CleverRaven/Cataclysm-DDA

How is it that wearing a bra inside a T-shirt would result in 2 encumbrance ?

Open

#65,145 opened on Apr 17, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedItems: Armor / Clothing[JSON]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

Currently wearing a bra inside a T-shirt would result in 2 encumbrance because they both occupy the same layer of clothing. However that not always the case IRL, NOT wearing a bra or some sort of close fit garment would result in some kind of encumbrance upon certain activities, at lease for most women that is. I think an "underwear" layer should be added to address this issue.

Attach save file

N/A

Steps to reproduce

  1. Make a female character
  2. See that the bra causes extra encumbrance

Expected behavior

An extra underwear layer for bra and bikini items. Or Some sort of negative encumbrance to offset the effect.

Screenshots

No response

Versions and configuration

latest stable

Additional context

No response

Contributor guide

Research direction
Investigate the clothing layer system in the game code to understand how encumbrance is calculated for overlapping layers. Look at how bras and T shirts are currently categorized and consider adding an 'underwear' layer or modifying the encumbrance calculation to account for undergarments.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50