CleverRaven/Cataclysm-DDA

Mine trolley is fine off rails and won't go back on

Open

#64,948 opened on Apr 9, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedVehicles

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

It is possible to drag the mine's trolley off of the rail it will spawn on, and it will work considerably well off-rail, so well it won't actually go back onto the rail.

Attach save file

TESTING-trimmed.tar.gz

Steps to reproduce

  1. Go to a mine's underground layer at -2 z-level
  2. Grab the trolley
  3. Walk away from its rail
  4. Be off the rails

Expected behavior

The trolley is rail bound, and if it happens to fall off of them, can be (relatively) easily set back onto them.

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 20.04.6 LTS; Release: 20.04; Codename: focal;
  • Game Version: d6ec466 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], No Fungal Growth [no_fungal_growth], Bionic Slots [cbm_slots], Tamable Wildlife [Tamable_Wildlife] ]

Additional context

No response

Contributor guide

Research direction
Investigate the rail trolley movement logic in the game's vehicle or map code. Look for how the trolley interacts with rails and whether there is a check that prevents it from being placed back on rails after being moved off. Potentially fix by adding a condition to allow the trolley to snap back onto rails when close enough.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45