CleverRaven/Cataclysm-DDA

Crash upon attempting to unload 3L jar full of other loaded containers. Experimental build 2023-02-08-0648.

Open

#63,490 opened on Feb 8, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)<Crash / Freeze>Help WantedItems: Containers[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

My game consistently crashes whenever I attempt to unload a 3L jar filled with three plastic bottles, two medium cans, and a belt, all of which also have items within them.

Attach save file

save.zip

Steps to reproduce

  1. Load the save.

  2. Press "U" and attempt to unload the 3L jar in the inventory.

  3. Game crashes.

Expected behavior

I expected the game to not crash when I try to to unload the jar.

Screenshots

No response

Versions and configuration

Experimental build 2023-02-08-0648

Additional context

No response

Contributor guide

Research direction
Investigate the crash when unloading a container that contains other loaded containers. Trace the unload logic in the game code, particularly for nested containers.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40