CleverRaven/Cataclysm-DDA

Items on the floor display improperly when (i)nserting.

Open

#63,103 opened on Jan 13, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Help WantedInfo / User InterfaceInventory / AIM / Zones

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

Items on the floor are sorted together with player's inventory instead of being displayed as separate category.

Steps to reproduce

  1. Have a player with a two big bags with stuff from multiple item categories in each.
  2. Drop any item on the floor
  3. Enter (i)nsertion menu of the first bag
  4. Observe item on the floor sorted as part of its category together with items in player's inventory in the second bag.

Expected behavior

Items on the floor sorted as a discrete category when (i)nserting, as per previous versions of the game.

Screenshots

No response

Versions and configuration

  • OS: Android
  • Game Version: fbdb628 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions], Aftershock [aftershock], Blaze Industries [blazeindustries], Magiclysm [magiclysm], Crazy Cataclysm [crazy_cataclysm], Mythical Martial Arts [MMA], Xedra Evolved [xedra_evolved], SpeedyDex [speedydex], Stats Through Kills [stats_through_kills]

Additional context

No response

Contributor guide

Research direction
Examine the inventory insertion menu sorting logic to understand why floor items are merged with player inventory categories instead of being displayed separately. Look for changes in sorting functions related to item categories.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60