CleverRaven/Cataclysm-DDA

attempting to craft something that "in progress" is over 1000L deletes the item

Open

#62,258 opened on Nov 17, 2022

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C++ (3,991 forks)batch import
(P3 - Medium)(S2 - Confirmed)Help Wanted[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

when you try to craft something that results in the "in progress " pseudo item volume exceeding the max volume of the crafting spot, the game throws an error and deletes the "in progress " pseudo item.

Steps to reproduce

  • set up a crafting spot with only 1000L of volume (ex fiber mat)
  • using the recipe that crafts heavy wooden beams using 6 logs and a tree cutting tool of 2. batch craft this recipe at least with the 4 times multiple.
  • observe the game throwing an error and deleting the items you were trying to craft.

Expected behavior

the game failing this issue in some way that does not result in player loosing items.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.2130 (21H2)
  • Game Version: 26a4725 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions], Xedra Evolved [xedra_evolved], No Hope [no_hope], Blaze Industries [blazeindustries], Aftershock [aftershock], Tamable Wildlife [Tamable_Wildlife], Stats Through Skills [StatsThroughSkills], Bionic Slots [cbm_slots], SpeedyDex [speedydex] ]

Additional context

  • the in progress recipe mentioned in the steps to reproduce are for some reason 300L per heavy wooden beam

  • the easiest fix I can think of is to cap the volume of in process pseudo items to 1000L

Contributor guide