CleverRaven/Cataclysm-DDA

Reduce sleep comfort if liquid or fields are on the tile you are sleeping

Open

#59,047 opened on Jul 7, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(P4 - Low)<Suggestion / Discussion>Fields / Furniture / Terrain / TrapsHelp WantedMechanics: Character / Player[C++]

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

That should make sleeping in a sort-of clean environment more desirable.

Solution you would like.

  1. If e.g a puddle of blood or a heap of gore or vomit is on your bed, reduce the comfort you get from sleeping and prohibit getting the well rested morale boost. Also apply a morale debuff because it is gross.
  2. The outdoorsman trait could make it easier to endure.
  3. Squeamish should prohibit sleeping in such conditions.
  4. Add a chance of an outer clothing part getting filthy when sleeping in a puddle of blood or heap of gore. Could also apply when being prone in such a field in general.

Basically account for any spilled liquid. I currently can not think of any that would be neutral.

The fields on the other hand are a bit more tricky. You should already see what I am aiming for. If there is just a blood splatter or these twigs and leaves from triffids it should be mostly fine. But a heap of gore, a puddle of blood and/or bile? "You find it gross and really hard to sleep in this yucky place".

Fog could be fine for the player, as would be tobacco smoke for smokers. Relaxation gas should not affect sleep in a negative way at all.

Describe alternatives you have considered.

No response

Additional context

No response

Contributor guide

Research direction
Examine the sleep mechanics in the game code, specifically how comfort and morale are calculated during sleep. Identify where tile fields and liquids are checked. Implement additional checks for specific field types (e.g., blood, gore, vomit) and liquid types. Modify comfort and morale adjustments, and add a chance for outer clothing to get filthy. Consider the outdoorsman trait and squeamish trait interactions.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Game development concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40