CleverRaven/Cataclysm-DDA

Remove FIRE_CONTAINER from oven furniture definition

Open

#56,343 opened on Mar 25, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
Fields / Furniture / Terrain / TrapsGood First Issue

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

Electric ovens IRL aren’t all that great at containing an actual fire, as they’re heat insulated with flame retardant insulation, but they’re not fireproof. Setting logs on fire in an oven would not only damage the electric heating elements and render it unusable, but it would also risk burning through the thin sheet metal bottom of the oven.

Solution you would like.

Removal of the FIRE_CONTAINER flag from f_oven. It only appears that the mapgen placed ovens are this way - the user placed oven appliance is not a fire container.

Describe alternatives you have considered.

No response

Additional context

This is an easy first issue. I can throw up a PR this weekend if nobody gets to it.

Contributor guide

Research direction
Locate the oven furniture definition file (likely `f oven` in a JSON file under `data/`) and remove the `FIRE CONTAINER` flag from it. Ensure that only mapgen placed ovens are affected if there is a separate definition for player placed ovens.
Tech stack
cpp
Domain
game dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85