CleverRaven/Cataclysm-DDA

"high quality distillate (heads)" recipe byproduct is excessive/inadequate

Open

#52,743 opened on Nov 10, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,991 forks)batch import
(S2 - Confirmed)Crafting / Construction / RecipesGood First Issue

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Describe the bug

the recipe for "high quality distillate (heads)" gives back as byproduct the same material it needs to be crafted, in increased quantity... literally creating items from nothing

Steps To Reproduce

1 spawn materials needed to make the whole ordeal 2 craft it 3 observe your starting ingredient "high quality distillate (tails)" growing in size

Expected behavior

i'm not an expert of oil refining, but this recipe goes against the laws of physics creating items from nothing

Screenshots

image

Versions and configuration

windows 10 version 6db9695 build 2021-11-10-0755

Additional context

No response

Contributor guide

Research direction
Check the recipe definition for 'high quality distillate (heads)' and correct the byproduct quantity to match the input amount.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJSON
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80