CleverRaven/Cataclysm-DDA

Overhead lights over floors don't look good when surrounding floor tiles are sprited with multitile support in tileset

Open

#46,028 opened on Dec 13, 2020

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C++ (3,991 forks)batch import
<Bug>Good First IssueSDL: Tiles / Sound

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

When floors are drawn as miltitile sprites with borders (latest Ultica) these borders create visible squares around overhead lights with the same floor in description and thus in background.

screenshot

Describe the solution you'd like

Not sure if it's worth it, but adding a new https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/JSON_INFO.md#connects_to might work.

Describe alternatives you've considered

Removing multitile support from floors in tileset sprites.

Additional context

https://github.com/I-am-Erk/CDDA-Tilesets/pull/320

Contributor guide

Research direction
Examine the connects to mechanism in tile definitions and how overhead lights interact with multitile floor sprites. Consider modifying the tile JSON to introduce a new connection type that prevents the overlay from rendering when multitile borders are present.
Tech stack
cpp
Domain
game dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++JSON
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60