CleverRaven/Cataclysm-DDA

Allow modifying/repairing guns on the ground and around you.

Open

#42,443 opened on Jul 25, 2020

View on GitHub
 (5 comments) (5 reactions) (0 assignees)C++ (3,991 forks)batch import
(P3 - Medium)<Suggestion / Discussion>Help WantedItems: Gunmod / ToolmodQuality of Life

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Game version:

  • Game Version: 83ce24e [64-bit] Operating system:
  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: ManjaroLinux; Description: Manjaro Linux; Release: 20.0.3; Codename: Lysia; Tiles or curses:
  • Graphics Version: Tiles Mods active:
  • Mods loaded: [ Dark Days Ahead [dda], No Fungal Monsters [No_Fungi], Fuji's Military Profession Pack [fuji_mpp], SpeedyDex [speedydex], Stats Through Kills [stats_through_kills], Stats Through Skills [StatsThroughSkills] ]

Expected behavior

Attach weapon mods or repair guns located on the tile you are standing on and 1+ tile away from you, just like sewing/~tailor's kit, soldering iron, and welder for their respective items.

Actual behavior

To modify/repair guns they must be either in your inventory or wielded. To modify (but not repair) clothing with a tailor's kit they must be either in your inventory or wielded.

Steps to reproduce the behavior

Activate firearm/gunsmith repair kit with batteries with sufficient charge and anything on the ground you are standing on and on the ground adjacent to you is not accessible for repair.

Contributor guide

Research direction
Investigate the game's interaction code to understand why items on the ground are not accessible for gun modification/repair. Check the functions that handle 'activate' actions for repair kits and compare with how clothing repair allows ground items.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65