CleverRaven/Cataclysm-DDA

items dropped by npcs before recruited still considered stealing if picked up

Open

#40,218 opened on May 5, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C++ (3,991 forks)batch import
<Bug>Help WantedNPC / Factions

Repository metrics

Stars
 (9,264 stars)
PR merge metrics
 (Avg merge 6d 5h) (292 merged PRs in 30d)

Description

Items dropped by npcs before being recruited by the player will still show a warning when examined

When an npc drops items, they are marked as owned by an npc, and picking them up is considered stealing. But once the npc is recruited by the player, the items dropped are still owned by an npc, and picking them up produces a warning that it would be considered stealing to take them.

Steps To Reproduce

  1. Npc drops items
  2. Recruit npc
  3. Examine dropped items

Expected behavior

Items dropped, like everything the npc had in their inventory, are readily usable and belong to the player, or are not owned at all.

Screenshots

image

Versions and configuration

(actual version used during crash was g70f064a) d

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-1783-g3ba1852 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], C.R.I.T Expansion Mod [crt_expansion], Dark Days Ahead: Lua [dda-lua], Dark Days Ahead: Lua (Fun) [dda-lua-fun], Dark Days Ahead: Lua (Items) [dda-lua-items], Dark Days Ahead: Lua (Traits) [dda-lua-traits], Magiclysm [magiclysm], Bootleg Walkers [Bootleg_Walkers], Gun Cotton [guncotton], Packaging [Packaging], Mining Mod [Mining_Mod], More Survivor Stuff [more_survivor_stuff], Jury-Rigged Robots [jury_rigged_robots], Fuji's Military Profession Pack [fuji_mpp], Mutation Changes [Mutation_Changes], SpeedyDex [speedydex], Stats Through Kills [stats_through_kills], Stats Through Skills [StatsThroughSkills], Alternative Map Key [alt_map_key], More City Locations [cityside] ]

Additional context

0.E-1783-g70f064a Crashed when trying to load: Durand.zip

crash.log

Updated version 0.E-1783-g3ba1852 and loaded:

Durand.zip

(debug log is on updated version and not when game crashed) debug.log

Contributor guide