ChocolateLoverRaj/pam-any

Should there be a (unsafe) gross hack mode?

Open

#15 opened on May 23, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (4 forks)auto 404
help wanted

Repository metrics

Stars
 (34 stars)
PR merge metrics
 (PR metrics pending)

Description

Based on https://github.com/lvkv/pam-rs/issues/13 and #3 , I determined that pam_conv (which is the Conv struct in the Rust bindings) cannot be sent across threads, and the unsafe send marking of Conv is not correct. I'm pretty sure pam-fprint-grosshack also sends pam_conv across threads and breaks the same rule that we do.

Sending Conv to another thread is needed in order to return from the sm_authenticate function before a prompt is complete. WIthout sending Conv to another thread, it would be less convenient for the user.

I see two options:

  • Remove gross hack mode completely
  • Remove gross hack mode by default but leave it as an option

I decided that I will add a gross hack mode if there is demand for it. However, it would be two separate binaries, one with 100% safe Rust (without gross hack), and one with the unsafe send on Conv (for gross hack). This way it isolates the unsafe from affecting non-gross hack usage.

Contributor guide

Research direction
Investigate the thread safety of pam conv and implement an optional unsafe send for Conv, ensuring it is gated behind a feature flag.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rustunsafe code understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40