Chocobozzz/PeerTube

Support disabling rates limit

Open

#6,089 opened on Dec 6, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (1,362 forks)batch import
Type: Feature Request :sparkles:good first issue

Repository metrics

Stars
 (11,911 stars)
PR merge metrics
 (Avg merge 17d 6h) (6 merged PRs in 30d)

Description

Describe the problem

This is my current rate limits configure

rates_limit:
  api:
    window: 10 seconds
    max: 0
  login:
    window: 5 minutes
    max: 0
  signup:
    window: 5 minutes
    max: 0
  ask_send_email:
    window: 5 minutes
    max: 0
  receive_client_log:
    window: 10 minutes
    max: 0
  plugins:
    window: 10 seconds
    max: 0
  well_known:
    window: 10 seconds
    max: 0
  feeds:
    window: 10 seconds
    max: 0
  activity_pub:
    window: 10 seconds
    max: 0
  client:
    window: 10 seconds
    max: 0

When I visit the page, I received 429 Too many request error.

If I want to set all peertube rate limits to unlimit in v6.0.1, what value should I set?

Additional information

  • PeerTube instance URL:
  • PeerTube version: v6.0.1
  • NodeJS version: v18.19.0
  • Ffmpeg version:
  • Redis version: 7.0
  • PostgreSQL version: 13.3

Contributor guide

Research direction
Investigate why setting max:0 triggers 429. Review the rate limit configuration parsing and middleware to see if 0 is handled as unlimited. Check for any documentation updates.
Tech stack
typescriptnodejspostgresqlredis
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70