ChartsOrg/Charts

Default colors should adapt to macOS Mojave dark mode

Open

#3,742 opened on Nov 11, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (28,002 stars) (6,009 forks)batch import
help wanted

Description

What did you do?

Rendered a chart under dark mode in Mojave.

What did you expect to happen?

Labels, grids, etc, to show in white color.

What happened instead?

Labels, grids, etc, show in black.

Charts Environment

Charts version/Branch/Commit Number:master Xcode version:10.1 Swift version:4.2 Platform(s) running Charts:macOS macOS version running Xcode:10.14.1 Mojave

Contributor guide

Tech stack
swift
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Swift knowledgeUnderstanding of macOS dark mode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Implement color adaptation using NSAppearance or system colors. Identify where default colors are defined (likely in ChartColorTemplates or base chart components) and modify them to respond to the current appearance. Check for SwiftUI or AppKit approaches for dynamic colors. The issue is available as no PR is linked, but ensure the solution works for both light and dark modes.