CI does not run on stacked PRs (pull_request trigger restricted to main)
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Open .github/workflows/ci.yml and inspect the pull_request trigger and its branch filter. Compare the workflow behavior for a pull request targeting main with one targeting another branch, then verify that stacked PRs receive the build, Zig tests, JavaScript tests, and lint checks. Done means pull requests against any base branch trigger CI while pushes remain limited to main.
Written by the indexing model from the issue text.
Description
Context
Noted while reviewing #56, which targets the fix/napi-out-parameters-v2 branch (stacked on #57). No CI checks ran on it because .github/workflows/ci.yml triggers only on:
on:
pull_request:
branches: [main]
Any PR whose base is another feature branch gets zero checks (build, zig tests, JS tests, lint), so stacked PRs can only be validated locally until the base PR merges or the PR is retargeted.
Proposal
Drop the branch filter on the pull_request trigger (or widen it) so CI runs for PRs against any base branch:
on:
pull_request:
push:
branches: [main]
Ref: .github/workflows/ci.yml
- Dominant language
- Zig
- Stars
- 4
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ChainSafe/zapi
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
clearer errors Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
repo:raw-data
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
hotosm/raw-data-api#316 · 1 comment ·
-
agentic-workflows cascade-suspected
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
willow
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
openedx/openedx-authz#460 ·