CI does not run on stacked PRs (pull_request trigger restricted to main)

Open Beginner friendly
#63 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
github-actions
Domain
ci-cd

Research direction

Open .github/workflows/ci.yml and inspect the pull_request trigger and its branch filter. Compare the workflow behavior for a pull request targeting main with one targeting another branch, then verify that stacked PRs receive the build, Zig tests, JavaScript tests, and lint checks. Done means pull requests against any base branch trigger CI while pushes remain limited to main.

Written by the indexing model from the issue text.

Description

Type: Maintenance

Context

Noted while reviewing #56, which targets the fix/napi-out-parameters-v2 branch (stacked on #57). No CI checks ran on it because .github/workflows/ci.yml triggers only on:

on:
  pull_request:
    branches: [main]

Any PR whose base is another feature branch gets zero checks (build, zig tests, JS tests, lint), so stacked PRs can only be validated locally until the base PR merges or the PR is retargeted.

Proposal

Drop the branch filter on the pull_request trigger (or widen it) so CI runs for PRs against any base branch:

on:
  pull_request:
  push:
    branches: [main]

Ref: .github/workflows/ci.yml

Dominant language
Zig
Stars
4
Forks
4
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ChainSafe/zapi

All issues in ChainSafe/zapi

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.