ChadCSong/ShineButton

In fragment don't work the explosion in the icon

Open

#24 opened on Mar 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (4,219 stars) (552 forks)batch import
help wanted

Description

Hi,

I'm trying to implement the library. The icon change the color and do the effect of the moviment, but is not working inside a fragment. If I copy the same code in an activity, it is working fine.

Have the library a problem working in a fragment?

Fragment code: @Override public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState);

    shineButton = (ShineButton) getView().findViewById(R.id.po_image0);
    shineButton.init((HomeActivity)getActivity());

    shineButton.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
        }
    });

}

XML code: <com.sackcentury.shinebuttonlib.ShineButton android:id="@+id/po_image0" android:layout_width="18dp" android:layout_height="18dp" app:btn_color="@color/colorGrey" app:btn_fill_color="#f26d7d" app:siShape="@raw/ico_social_like" android:layout_marginTop="@dimen/margin_10" android:layout_marginLeft="@dimen/margin_20" android:layout_marginStart="@dimen/margin_20" android:elevation="10dp"/>

Contributor guide

Tech stack
javaandroid
Domain
frontendmobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentFragments lifecycleShineButton library setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Explore the ShineButton library source code, specifically the init() method that requires an Activity context. In a Fragment, the context might differ; investigate how the library handles context and whether it needs to be passed the parent Activity's context properly. Consider that the user already uses init((HomeActivity)getActivity()), but maybe the explosion effect relies on a Window or other Activity specific reference. Check if there are any known workarounds or if the library's explosion animation uses a WindowManager that expects an Activity context. Possible fix: passing the Activity context or ensuring the library's internal state is correctly associated with the Fragment's parent Activity.