CesiumGS/cesium

Update zip.js dependency to latest

Open

#8,092 opened on Aug 20, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
good first issuetype - enhancement

Description

Per the zip.js devs, Cesium is using an older build and it results in instantiating a new web worker for every file added to a ZIP (!!!), greatly slowing the process. This only showed up recently because the KML exporter is probably the first part of Cesium that needs to make ZIP files.

Contributor guide

Tech stack
javascript
Domain
performance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with npm or yarnUnderstanding of dependency updatesBasic knowledge of Cesium's build process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the current zip.js version used in Cesium by searching package.json or equivalent files. Refer to zip.js issue #139 (https://github.com/gildas lormeau/zip.js/issues/139) for the recommended version that fixes the excessive worker instantiation. Update the dependency version in the appropriate configuration file and verify that the KML exporter works correctly without performance degradation.