CesiumGS/cesium

GeocoderViewModel.search command not executed when user clicks a suggestion

Open

#6,313 opened on Mar 6, 2018

View on GitHub
 (16 comments) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
JTCcategory - widgetsgood first issueonramping

Description

Brought up on the forum here: https://groups.google.com/forum/#!topic/cesium-dev/IH6VTxePo3o

The search command executes when the user types a search and hits enter or clicks the search button, and also when selecting a suggestion form the drop down list with the arrow keys and enter, but not when clicking a suggestion with the mouse.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptUnderstanding of Cesium's Geocoder
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the click event handling on suggestion items in the Geocoder component. Focus on how the `search` command is triggered when a suggestion is selected via keyboard vs mouse. Look at the source code for GeocoderViewModel, specifically the event listeners attached to suggestion elements. The forum link provides additional context. Consider comparing the mouse click handler with the keyboard enter handler to identify missing command execution.