CesiumGS/cesium

GeoJsonDataSource sourceUri parameter isn't used

Open

#6,108 opened on Jan 10, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
JTCgood first issue

Description

The GeoJsonDataSource.load() has a sourceUri parameter that isn't used to resolve relative links as GeoJSON files don't have any. It is used to get the datasource name, which can be set on creation of the datasource. This can be removed.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptCesium library familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue identifies that the `sourceUri` parameter in `GeoJsonDataSource.load()` is unused except for setting the datasource name. The fix involves removing the parameter and updating any internal references. The relevant file is likely `Source/DataSources/GeoJsonDataSource.js` in the Cesium repository.