CesiumGS/cesium

Rename PerspectiveFrustum.fov to PerspectiveFrustum.fieldOfView

Open

#5650 opened on Jul 19, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
breaking changecategory - architecture / apigood first issue

Description

See https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/PerspectiveFrustum.js#L42

Also search to see if fov is used anywhere else in the public Cesium API. The abbreviation is fine in the private interfaces and implementations.

Contributor guide

Tech stack
javascript
Domain
apifrontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptCesium API conventions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate the `fov` property in `Source/Core/PerspectiveFrustum.js` and rename it to `fieldOfView`. Then search the entire codebase for all public API usages of `fov` to update them accordingly, ensuring backward compatibility is not broken by keeping the abbreviation in private interfaces. Update any relevant tests or documentation.