CesiumGS/cesium

Rename PerspectiveFrustum.fov to PerspectiveFrustum.fieldOfView

Open

#5,650 opened on Jul 19, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (3,324 forks)batch import
breaking changecategory - architecture / apigood first issue

Repository metrics

Stars
 (11,758 stars)
PR merge metrics
 (Avg merge 15d 12h) (23 merged PRs in 30d)

Description

See https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/PerspectiveFrustum.js#L42

Also search to see if fov is used anywhere else in the public Cesium API. The abbreviation is fine in the private interfaces and implementations.

Contributor guide

Research direction
Search for all public usages of 'fov' in the Cesium API and rename to 'fieldOfView'.
Tech stack
javascript
Domain
web dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90