CesiumGS/cesium

Add "disableSecurity" option to InfoBox

Open

#5,446 opened on Jun 9, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
category - widgetsgood first issuetype - enhancement

Description

See this thread: https://groups.google.com/d/msg/cesium-dev/Ktn8aPQmOsQ/_Dbd7igkCQAJ

While we expose the ability to disable iframe sandboxing, some use cases need the title text to be HTML as well, which is currently using the knockout text binding instead of HTML. This will also help with the fact that most people aren't familiar with iframe sandboxing and we can provide them a single top-level property for disabling it.

This should be a simple change in InfoBox.js, see the above thread for some more details.

Contributor guide

Tech stack
javascripthtml
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Cesiumknockout.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The change should be made in InfoBox.js, likely modifying the InfoBoxViewModel to add a disableSecurity option. The knockout text binding should be changed to html binding when the option is enabled. Refer to the linked Google Groups thread for more context.
Add "disableSecurity" option to InfoBox · CesiumGS/cesium#5446 | Good First Issue