CesiumGS/cesium

Remove Safari 9 WebGL constants workaround

Open

#5,315 opened on May 11, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
category - graphicsgood first issuetype - cleanup

Description

The fix for #2989 is no longer needed: https://twitter.com/grorgwork/status/862784930048114688

Perhaps in a few years we can remove it when Safari 9 is no longer used.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Cesium's rendering codeUnderstanding of WebGL constants
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Refer to the linked tweet that indicates the workaround is no longer necessary. Search the codebase for references to Safari 9 or the specific WebGL constants mentioned in issue #2989. Remove the conditional code and verify that the library works correctly without the workaround.