CesiumGS/cesium

Replace "can support 2xx HTTP status (other than 200)" test

Open

#3757 opened on Mar 23, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (11,758 stars) (3,324 forks)batch import
good first issuetest failure

Description

The test can support 2xx HTTP status (other than 200) occasionally fails because it's relying on an external server that seems to have spotty availability. This causes CI to someone fail for no good reason. We should update this test to spy/mock the XHR request so that it doesn't need to access the network at all.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript fundamentalsTesting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Find the test file for 'can support 2xx HTTP status (other than 200)' test. Investigate the current implementation that relies on an external server. Implement a mock or spy for the XHR request to simulate a 2xx response without network access. Ensure the test passes consistently.