Minor alignment glitch in proof tableau
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start in frontend/src/app/annotate/tableau-svg/tableau-node.component.ts at lines 72-79 and inspect how mainW and totalW determine node alignment. Reproduce the tableau layout shown in the issue; it is done when the first line is centered on its tree branch while totalW still prevents adjacent branches from overlapping.
Written by the indexing model from the issue text.
Description
@XanderVertegaal shared this gorgeous screenshot with me:
In nodes 4 and 6, the first line with the id label, head term and argument is left-aligned with the rule on the second line, instead of being centered on the tree branch. This is related to the following piece of code:
In a prior version, totalW used to be the same value as mainW (in fact there was no separate mainW). The alignment of the first line of each node is still based on the (now false) assumption that totalW reflects the width of the top line. Hence, if the rule is wider than the first line (which is rare), the first line is left-aligned with the rule.
Solution: make mainW a property of the component and use this for alignment of the first line instead of totalW.
Side note: totalW is still needed to prevent nodes on adjacent branches from overlapping.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 7d 5h
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CentreForDigitalHumanities/langpro-annotator
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bonus enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CentreForDigitalHumanities/langpro-annotator#117 · 1 comment · 1 reaction ·
-
enhancement good first issue
CentreForDigitalHumanities/langpro-annotator#139 · 1 reaction · 1 assignee ·
-
enhancement
CentreForDigitalHumanities/langpro-annotator#138 · 1 comment · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
All issues in CentreForDigitalHumanities/langpro-annotator
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100