CenterForDigitalHumanities/rerum_server_nodejs

/query Hard Crash

Open

#115 opened on Mar 28, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (4 forks)auto 404
OSSbuggood first issue

Repository metrics

Stars
 (3 stars)
PR merge metrics
 (PR metrics pending)

Description

A /query body that causes a hard crash. Can we handle this situation better? I did not look into it, just noting it.

{
   "@type":"sc:AnnotationList",
   "on":{
      "$or":[
         {
            "on":"https://iiif.library.utoronto.ca/presentation/v2/paleography:419"
         },
         {
            "on":"https://paleography.library.utoronto.ca/islandora/object/paleography:419"
         }
      ]
   },
   "isPartOf":"2888",
   "__rerum.history.next":{
      "$exists":true,
      "$size":0
   }
}

Yes, I know. That is now how you use $or. Still, this caused a hard 500 that did not return anything RESTful

Contributor guide

Research direction
Add error handling for malformed JSON in the /query endpoint to return a proper error response instead of crashing.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80