Carthage/Carthage

Carthage fails if dependency changes a tag

Open

#2,786 opened on May 13, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (15,179 stars) (1,544 forks)batch import
bughacktoberfesthelp wanted

Description

  • carthage install method: homebrew
  • which carthage: /usr/local/bin/carthage
  • carthage version: 0.33.0
  • xcodebuild -version: Xcode 10.2.1, Build version 10E1001
  • Are you using --no-build? no
  • Are you using --no-use-binaries? no
  • Are you using --use-submodules? no
  • Are you using --cache-builds? yes
  • Are you using --new-resolver? no

Cartfile

github "instacart/TrueTime.swift"

I'm running /usr/local/bin/carthage outdated --xcode-warnings as part of our build process. Unfortunately this command started failing, which causes our build to fail.

Carthage Output

*** Fetching TrueTime.swift
A shell task (/usr/bin/env git fetch --prune --quiet https://github.com/instacart/TrueTime.swift.git refs/tags/*:refs/tags/* +refs/heads/*:refs/heads/* (launched in /Users/manselm/Library/Caches/org.carthage.CarthageKit/dependencies/TrueTime.swift)) failed with exit code 1

Running the git command to see what's wrong, it looks like the TrueTime folks did something weird with a tag

/usr/bin/env git fetch --prune https://github.com/instacart/TrueTime.swift.git refs/tags/*:refs/tags/* +refs/heads/*:refs/heads/*
From https://github.com/instacart/TrueTime.swift
 ! [rejected]        5.0.1      -> 5.0.1  (would clobber existing tag)

Expected output

Carthage's cache was out of date. It should be able to detect this and refresh its own cache, not fail.

Contributor guide

Tech stack
swiftshell
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of GitUnderstanding of Carthage's caching mechanism
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue occurs when a remote repository changes a tag that was previously fetched. Carthage's git fetch command uses prune but does not handle tag changes gracefully. The fix could involve deleting the local tag before fetching, or comparing the tag's commit hash. Key files to examine are CarthageKit/GitFetcher.swift and the caching logic in Project.swift. A linked PR might be needed to implement a solution that updates local tags when they diverge from remote.