Carthage/Carthage

New resolver output does not match old resolver · in this situation, all dependencies lack specifiers in the root-level Cartfile

Open

#2,421 opened on Apr 16, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Swift (15,179 stars) (1,544 forks)batch import
bughelp wanted

Description

  • carthage install method: homebrew
  • which carthage: /usr/local/bin/carthage
  • carthage version: 0.29.0
  • xcodebuild -version: Xcode 9.3 Build version 9E145

Cartfile

github "ReactiveX/RxSwift"
github "RxSwiftCommunity/RxOptional"
github "RxSwiftCommunity/RxSwiftExt"

github "Quick/Nimble"
github "Quick/Quick"
github "uber/ios-snapshot-test-case"

Carthage Output

carthage update --no-build --new-resolver

*** Fetching RxOptional
*** Fetching RxSwiftExt
*** Fetching ios-snapshot-test-case
*** Fetching Nimble
*** Fetching Quick
*** Fetching RxSwift
*** Checking out RxOptional at "3.4.1"
*** Checking out RxSwiftExt at "3.2.0"
*** Checking out ios-snapshot-test-case at "3.0.0"
*** Checking out Nimble at "v7.1.0"
*** Checking out Quick at "v1.2.0"
*** Checking out RxSwift at "4.0.0"

Carthage Output

carthage update --no-build

*** Fetching RxSwift
*** Fetching Quick
*** Fetching Nimble
*** Fetching ios-snapshot-test-case
*** Fetching RxSwiftExt
*** Fetching RxOptional
*** Checking out RxOptional at "3.4.1"
*** Checking out RxSwiftExt at "3.2.0"
*** Checking out ios-snapshot-test-case at "3.0.0"
*** Checking out Nimble at "v7.1.0"
*** Checking out Quick at "v1.2.0"
*** Checking out RxSwift at "4.1.2"

The new resolver checks out RxSwift 4.0.0, whereas the old resolver checks out 4.1.2. This was the smallest Cartfile I could find that would reproduce this issue. Although I used --no-build here, I see the same issue without it.

Contributor guide

Tech stack
swift
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with CarthageSwift programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Focus on the resolver implementation in the 'CarthageKit' module. Compare the old and new resolver algorithms to understand why the new resolver selects RxSwift 4.0.0 instead of 4.1.2 when dependencies lack specifiers. Review the Cartfile and related comments in the issue for additional context.
New resolver output does not match old resolver · in this situation, all dependencies lack specifiers in the root-level Cartfile · Carthage/Carthage#2421 | Good First Issue