CaptainFact/captain-fact

Adapt background sound volume based on video volume

Open

#93 opened on Apr 1, 2019

View on GitHubContributor guide
 (9 comments) (0 reactions) (0 assignees) (7 forks)auto 404
bountybounty > 30€complexity > simplefrontendgood first issue

Repository metrics

Stars
 (71 stars)
PR merge metrics
 (PR metrics pending)

Description

We should retrieve the volume from ReactPlayer and adapt background notifications volume accordingly. As of today the volume can be too strong or too low.

  • Store the volume from ReactPlayer in redux state
  • Retrieve the value in app/components/App/BackgroundNotifier.jsx
  • Set audiofile.volume = ___ for all notifications types (refute/confirm/neutral)

Contributor guide

Research direction
Explore how ReactPlayer exposes volume via onProgress or getCurrentTime; then store volume in Redux and use it in BackgroundNotifier to set audiofile.volume for each notification type.
Tech stack
reactjavascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactReduxGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60