Canop/broot

Image rendering not "full quality" on Wezterm

Open

#509 opened on Feb 20, 2022

View on GitHub
 (10 comments) (3 reactions) (0 assignees)Rust (9,383 stars) (213 forks)batch import
bughelp wantedwindows

Description

I tried previewing .pngs on Broot using Wezterm on Windows and while Wezterm offers HD image previews with its imgcat function, Broot displays a poor image preview (blocky image preview). On Windows (WezTerm)

Whereas WezTerm's imgcat is much sharper: image

What am I missing, since the website mentions that Wezterm supports clear images here?

Contributor guide

Tech stack
rust
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programming basicsImage rendering concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate why Broot's image preview is lower quality than WezTerm's imgcat. Compare the image rendering methods: Broot likely uses the `image` crate and sends terminal escape sequences, while WezTerm's imgcat uses a different protocol or higher resolution. Look at Broot's preview module in `src/preview/` and examine how images are encoded and transmitted. Check if Broot is downscaling or using a lossy format. Also explore WezTerm's documentation for its imgcat implementation to see if there's a supported higher quality approach that Broot could adopt.