CERN/TIGRE

Add wrap algorithms to stop code repetition

Open

#210 opened on Dec 3, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)MATLAB (248 forks)batch import
MATLABenhancementhelp wanted

Repository metrics

Stars
 (771 stars)
PR merge metrics
 (Avg merge 1h 23m) (1 merged PR in 30d)

Description

There are several codes, such as OS-SART, SIRT, SART, or AwPCSD, OS-AwPCSD (etc) that are essentially the same algorithm but with a block-based update or a per-projection update. In theory, we could just have a single algorithm, e.g. OS-AwPCSD, and then AwPCSD would just be a wrapper to OS-AwPCSD, but with a fixed block size of 1.

This will make everything much tidyer .

Contributor guide

Research direction
Review the source files for the algorithms mentioned (OS SART, SIRT, SART, AwPCSD, OS AwPCSD) in the TIGRE repository. Identify duplicated code sections and design a wrapper strategy so that AwPCSD calls OS AwPCSD with block size 1. Ensure the wrapper does not alter algorithmic behavior. Propose a plan with specific changes needed.
Tech stack
None
Domain
data
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Basic knowledge of iterative reconstruction algorithmsFamiliarity with MATLAB/Octave scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40