Byron/trash-rs

Use references in `restore_all` and `purge_all`

Open

#54 opened on Jul 17, 2022

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Rust (40 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (247 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

restore_all and purge_all should take references because they don't need the ownership of TrashItems. This could reduce cloning when calling the functions. restore_all might need an additional clone on a RestoreCollision error because there is remaining_items. My use case is specified in #53 .

Contributor guide

Research direction
Change `restore all` and `purge all` to take `&[TrashItem]` instead of `Vec<TrashItem>`. Adjust internal code to work with references, and handle the `RestoreCollision` error by cloning the remaining items if needed.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75