BurntSushi/ripgrep

improve error messages when -f flag fails

Open

#478 opened on May 9, 2017

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Rust (2,559 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (63,768 stars)
PR merge metrics
 (Avg merge 2d 12h) (5 merged PRs in 30d)

Description

For example:

$ rg -e foo -f src/search_stream.rs 
Error parsing regex near 'fer.|*/|z{' at character offset 213: Invalid application of repetition operator to: '(?u:f)(?u:o)(?u:o)|(?u:/)*(?u:!)|(?u:T)(?u:h)(?u:e)

Aside from the badly formatted regex error message (see #395), the error message should show the file path and probably also the line number at which the error occurred.

Contributor guide

Research direction
Locate where the regex error for the f flag is produced, then modify it to include the file path and line number.
Tech stack
rust
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80