BuilderIO/mitosis

SolidJS: migrate `css` prop solution to solid-styled

Open

#947 opened on Dec 7, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (9,803 stars) (411 forks)batch import
enhancementgood first issuesolid

Description

Migrate our approach for the css prop in the SolidJS generator from using https://github.com/solidjs/solid-styled-components to using https://github.com/lxsmnsyc/solid-styled (as recommended by some folks in the SolidJS Community)

Contributor guide

Tech stack
typescriptsolidjs
Domain
frontendtooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SolidJSTypeScriptMitosis generator architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
First, locate the current implementation of the `css` prop in the SolidJS generator, likely in `packages/core/src/generators/solidjs.ts`. Review how `solid styled components` is currently imported and used. Then, examine the API of `solid styled` (https://github.com/lxsmnsyc/solid styled) to understand its equivalent for the `css` prop. The migration involves replacing imports and adapting the usage to the new library's API. Check the issue comments (if any) for additional context on suggested approaches.
SolidJS: migrate `css` prop solution to solid-styled · BuilderIO/mitosis#947 | Good First Issue