BuilderIO/mitosis

core: add new fields to MitosisComponent type: slots

Open

#325 opened on May 8, 2022

View on GitHub
 (10 comments) (0 reactions) (0 assignees)TypeScript (9,803 stars) (411 forks)batch import
coreenhancementhelp wanted

Description

export const createMitosisComponent = (
  options?: Partial<MitosisComponent>,
): MitosisComponent => ({
  '@type': '@builder.io/mitosis/component',
  imports: [],
  inputs: [],
  meta: {},
  state: {},
  children: [],
  hooks: {},
  context: { get: {}, set: {} },
  name: options?.name || 'MyComponent',
  subComponents: [],
  ...options,
});

a component needs to have all named slots available and I think it should be added here. and inside of children we need Slot nodes

'@type': '@builder.io/mitosis/component',
  slots: {
    mySelectorName: createMitosisComponent({})
  },
  children: [
    createMitosisNode({
      name: 'Slot',
      properties: {
        name: 'mySelectorName'
      } 
    });
  ],

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with TypeScriptunderstanding of Mitosis component model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the existing `createMitosisComponent` function in the codebase (likely in a file like `packages/core/src/create mitosis component.ts`). Add a `slots` property of type `Record<string, MitosisComponent>` to the `MitosisComponent` interface. Then update the default function to include an empty slots object. Also, ensure that slot nodes can be represented in the children array as shown in the issue description. Check for any existing discussions in comments for further context.