`tmd==2.2.0` changed slightly the API

Open
#86 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python

Research direction

Start in morphoclass/utils.py around line 53, where SectionType.basal_dendrite indexes TYPE_DCT with "basal". Inspect the tmd 2.2.0 API and nearby uses of TYPE_DCT to determine the compatible key mapping. Done means importing morphoclass.utils succeeds with tmd 2.2.0 without the KeyError.

Written by the indexing model from the issue text.

Description

TYPE_DCT is a dictionary created by tmd package and the key values changed in the new version 2.2.0

 from morphoclass.utils import print_warning                                                                                                                                                            
  File "/gpfs/bbp.cscs.ch/project/proj148/home/dictus/play_with_morphology/morphoclass/venv/lib/pyth                                                                                                       
on3.8/site-packages/morphoclass/utils.py", line 53, in <module>                                                                                                                                            
    SectionType.basal_dendrite: TYPE_DCT["basal"],                                                                                                                                                         
KeyError: 'basal'   
Dominant language
Python
Stars
12
Forks
6
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BlueBrain/morphoclass

All issues in BlueBrain/morphoclass

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.