Modes not working -> Extend unit test

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start at lifehash/lifehash.py line 1024 and inspect how hashlib.sha256 values are combined under Python 3.13. Review the existing unit tests, which currently cover only version2, then run them while checking the other LifeHash modes. Done means the failing hashing path is handled and tests cover all modes.

Written by the indexing model from the issue text.

Description

Hy dear LifeHash developers,

nice project. Yet, using you code with python 3.13 sadly made some issues.
It seems you are expecting to have the "+" operator to be defined on a hashlib.sha256 as well as hashlib.sha256 on another hashlib.sha256 ( sha256(sha256(bytes)) ).
lifehash/lifehash.py line 1024 thus fails. I think you just need to add a few .digest() here and there.

I get why you did not see that. I strongly suggest to extend you unit tests to test all modes for you LifeHash. Currently you only test version2.

Dominant language
Python
Stars
1
Forks
1
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BlockchainCommons/bc-lifehash-python

All issues in BlockchainCommons/bc-lifehash-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.