[SSKR] Not needed Android resources included

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
android, java
Domain
mobile

Research direction

Start in the SSKR library's android folder and inspect how its resources and manifest are packaged into the generated AAR. Verify that unnecessary mipmap, values, and color resources no longer reach consuming apps, that launcher icons are not overridden, and that allowBackup does not force a manifest replacement clause.

Written by the indexing model from the issue text.

Description

Reporting this issue for SSKR lib but I believe this could be happening to the rest of the ecosystem.

There are certain Android resources in the android folder from SSKR lib that get included in the aar generated library and so included in the project that is using the file. These resources (mipmap, values, colors...) are not needed and they add some extra space to the APK. Launcher icon is overriding the one in the app using the library (if using the same name).

Also the manifest is specifying the allowBackup=true, which forces apps using the library to add a replace clause in the manifest.

I'm preparing a PR to fix this. I won't include the rest of the libs as it will require testing, and we don't have in place any project using the rest of the libs just yet.

Dominant language
Java
Stars
4
Forks
4
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.