Blizzard/node-rdkafka

Question about commit and disconnect after connection is lost

Open

#27 opened on Aug 30, 2016

View on GitHub
 (6 comments) (0 reactions) (1 assignee)JavaScript (385 forks)batch import
help wantedquestion

Repository metrics

Stars
 (1,979 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I noticed that when commit is called while connection to kafka is lost, the function never returns or throws any error.

How should I recover from this state?

I could set a timeout and assume the connection is lost if the function does not return within that period and try to establish connection with a different kafka server. However, the disconnect function does not return either when connection is lost. How do I perform the necessary clean up without the disconnect function?

Thanks in advance

Contributor guide

Research direction
Examine the source code of node rdkafka to see how commit handles disconnections; check if there is a callback or timeout mechanism. Consider adding error handling or timeout to the commit operation.
Tech stack
javascript
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsKafka
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70