Relax `1:n` check (false positive)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start by locating BiocCheck's check for 1:n patterns and review how it distinguishes literal and variable expressions. Verify the behavior with the examples in the issue: 1:10 should not trigger the warning, while 1:n should continue to do so.
Written by the indexing model from the issue text.
Description
BiocCheck will complain on patterns such as:
1:10
But I think this is fine if the second element is an integer literal. The danger of 1: only lies when the second element is a variable is:
1:n
I believe having this check lump both cases together is doing a disservice to users as it doesn't help them understand why and when : is bad.
It also makes BiocCheck unnecessary noisy and teaches users to ignore it, even for a number of important issues currently reported in existing packages.
- Dominant language
- R
- Stars
- 10
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Bioconductor/BiocCheck
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
Bioconductor/BiocCheck#261 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 75/100
Bioconductor/BiocCheck#259 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
Bioconductor/BiocCheck#247 ·
-
Intermediate
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Bioconductor/BiocCheck#68 · 2 comments ·
-
Beginner
Bioconductor/BiocCheck#67 · 12 comments · 1 assignee ·
All issues in Bioconductor/BiocCheck
Similar issues
-
documentation pkg infrastructure
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
epiverse-trace/epiparameter#511 ·
-
function:write_dwc
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Urgent request: Due to vulnerabilities move to API version 12.6.1 (12.6.2 eventually) or 13.1.1 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jbkunst/highcharter#849 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100