BetterErrors/better_errors

allow custom favicon

Open

#362 opened on Mar 8, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Ruby (6,874 stars) (433 forks)batch import
enhancementgood first issue

Description

we have some pages that use a different favicon (or non .ico icons)

I think custom path might be the way to go, since that favicon caches are super long

Many thanks for such great errors

Contributor guide

Tech stack
ruby
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Ruby basicsRack basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding a configuration option for custom favicon path. The current implementation likely uses a default favicon. Implementation would involve adding an option to the configuration module (e.g., `BetterErrors.configure` block) and using that path in the error page HTML. The commenters may have suggestions; check the issue discussion at https://github.com/BetterErrors/better errors/issues/362 for any proposed solutions or blockers.