BeeStation/NSV13

*fingergun emote issue

Open

#1,468 opened on Jun 21, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)DM (124 stars) (267 forks)batch import
BugGood first issueHacktoberfestNeeds Reproduction StepsStaleUpstream Issue

Description

Round ID: 2625

Testmerges:

https://github.com/BeeStation/NSV13/pull/1422

Reproduction:

I was playing around with the *fingergun emote a lot and I was switching between Ruben and Joaquin often with the manual aim. After that, Ruben walked away and I wasn't locking onto him anymore, but it still told me when he dropped something and took something out.

Contributor guide

Tech stack
None
Domain
None
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with DM languageUnderstanding of SS13 emote system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the *fingergun emote code in the repository, possibly in emote related files. Check the testmerge PR #1422 for changes that might have introduced this bug. Reproduce the steps: switch between users with manual aim and observe the lingering tracking after target walks away. Identify where the emote tracking state is cleared and ensure it resets properly when the target is no longer locked.