Implement Object::Delete for Node-API-JSI

Open Beginner friendly
#234 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
cpp
Domain
api

Research direction

Start in Core/Node-API-JSI/Include/napi/napi-inl.h and locate the Napi::Object::Delete overloads that currently throw std::runtime_error("TODO"). Reproduce the issue with the provided object.Set("value", 1) and object.Delete("value") example. Done means the property is deleted, the result is returned, and the call no longer throws.

Written by the indexing model from the issue text.

Description

[Filed by Copilot on behalf of @bghgary]

Describe the bug

Node-API-JSI’s Napi::Object::Delete overloads throw std::runtime_error("TODO") instead of deleting the requested property. The implementation is currently stubbed.

To Reproduce

auto object = Napi::Object::New(env);
object.Set("value", 1);
object.Delete("value");

The final call throws "TODO".

Expected behavior

Object::Delete should delete the property and return the result without throwing.

Screenshots

N/A

Other

  • Platform: Windows x64 with the JSI backend.
Dominant language
C++
Stars
22
Forks
23
Avg merge
6d 17h
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BabylonJS/JsRuntimeHost

All issues in BabylonJS/JsRuntimeHost

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.