CodeCompliance_Engine: Check Adapter namespaces contain external

Open
#181 1 comment 0 reactions 4 assignees View on GitHub

Nobody has claimed this yet.

Assessment

This issue has not been assessed yet.

Description

type:feature type:question

Linked to: 1) https://github.com/BHoM/Test_Toolkit/issues/72#issuecomment-596234396

And: 2) https://github.com/BHoM/BHoM_Adapter/issues/210

And: 3) https://github.com/BHoM/Test_Toolkit/issues/72#issuecomment-596416344

There is a new compliance rule that adapter projects namespace should be as described in 2 above.

However, we have previously found that namespace checking can be tricky to cover for all situations when running CI checks. Previously we did it based on the filepath which looked for the toolkit name, but this prevented the ability to inject into existing namespaces without flagging as a CI fail.

We would need a similar set of discrete rules which allow the CI to know if a namespace should include the External keyword or not.

This issue is to discuss that, and see if such a set of clear rules can be found that will allow for the creation of a CI check to aid us in keeping compliance on this new rule.

Dominant language
C#
Stars
0
Forks
1
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BHoM/Test_Toolkit

All issues in BHoM/Test_Toolkit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.