Maximum total budget for a proposal changes from year to year

Open
#186 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
html
Domain
backend, web-dev

Research direction

Start at api/templates/pages/budget.html#L133 and trace how the proposal form gets its current warning value. Then inspect the Set Parameters page and the production data for previous years to identify where stipend and other-budget values belong. Done means both values are configurable, the warning checks them separately for multiple faculty, and prior-year data remains populated.

Written by the indexing model from the issue text.

Description

Faculty stipends (which is solved by PR #183) brings about another issue, which is there is a warning hard-coded into the end of the proposal form which notifies the user that their proposal is over a certain amount: https://github.com/BCStudentSoftwareDevTeam/urcpp/blob/development/api/templates/pages/budget.html#L133

This number should be dynamic, which means it needs to be programmable in the Set Parameters page.

However, the current number ($8300) was derived from a $5300 faculty stipend (now wrong) + $3000 max budget for everything else (which may also change in the future). Worse yet, this doesn't take into consideration the fact that two or more faculty could be on a proposal, which would make the budget: 5300 + 5300 + 3000.

So, this needs reworked so that faculty stipends are treated separately from the other budget calculations when this warning is displayed. In reality, it should only be a check on the $3000 budget for everything else, and a separate check on the stipend based on the number of faculty on the proposal.

Both the stipend and the "everything else budgets" should be set in the Set Parameters page so they can change each year.

You'll also want to check the impact of this on previous years (i.e., fix the production data so the value is in there).

Dominant language
HTML
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BCStudentSoftwareDevTeam/urcpp

All issues in BCStudentSoftwareDevTeam/urcpp

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.