BAndysc/WoWDatabaseEditor

Action Invoker source/target doesn’t work with `wait` meta action

Open

#33 opened on Feb 3, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (168 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (561 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug ActionInvoker is null after wait action.

Version (commit hash) d2ad04b3f53abf5738ab2e178f3a2796d52e66fe

To Reproduce Steps to reproduce the behaviour:

  1. Create a script
  2. Create any event which has „invoker”
  3. Add action wait
  4. Add any action with invoker source
  5. Test in game - doesn’t work, because invoker is null there

Expected behaviour Action Invoker should work as expected after wait action.

Proposed solution Best option would be to change TC to pass invoker here https://github.com/TrinityCore/TrinityCore/blob/master/src/server/game/AI/SmartScripts/SmartScript.cpp#L1542

Another option would be to change invoker to storedTarget in the editor, but there is a risk, this storedTargetID will be taken already. We can inform user during exporting that some storedTarget will be reserved?

Contributor guide

Research direction
Explore how the editor generates smart scripts from action tables, focusing on how 'invoker' is assigned as source/target. Then examine the generated output for a script containing a wait action to see why invoker becomes null. Consider the links to TrinityCore's SmartScript.cpp to understand the server side behavior.
Tech stack
csharp
Domain
game devtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#Smart Scripts (SAI)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65