Crash if duplicate model names (across files) used in allOf

Open

#479 opened on May 5, 2026 2 comments 0 reactions 1 assignee View on GitHub

@mikeharder is already working on this.

Since May 5, 2026.

Assessment

This issue has not been assessed yet.

Description

A TSP conversion PR resulted in this error:

"details":"incompatible properties : tags

definitions/ContainerGroup/properties/tags
 at file:///home/runner/work/azure-rest-api-specs/azure-rest-api-specs/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/ContainerInstance/stable/2025-09-01/containerInstance.json#L2245:8

definitions/Resource/properties/tags
  at file:///home/runner/work/azure-rest-api-specs/azure-rest-api-specs/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/ContainerInstance/stable/2025-09-01/containerInstance.json#L4642:8"

Root cause, oad cannot handle two definitions in different files with the same name, if one definition is used in an allOf:

duplicate-names.json

{
  "swagger": "2.0",
  "info": {
    "title": "duplicate-names",
    "version": "1.0"
  },
  "paths": {},
  "definitions": {
    "Bar": {
      "type": "object",
      "properties": {
        "p1": {
          "type": "string"
        }
      },
      "allOf": [
        {
          "$ref": "./common-types.json#/definitions/Foo"
        }
      ]
    },
    "Foo": {
      "type": "object",
      "properties": {
        "p1": {
          "type": "object"
        }
      }
    }
  }
}

common-types.json

{
  "swagger": "2.0",
  "info": {
    "title": "common-types",
    "version": "1.0"
  },
  "paths": {},
  "definitions": {
    "Foo": {
      "type": "object",
      "properties": {
        "p1": {
          "type": "string"
        }
      }
    }
  }
}

test result

    incompatible properties : p1
      definitions/Bar/properties/p1
        at file:///home/mharder/openapi-diff-mh/incompat-prop/src/test/specs/incompatible-properties/duplicate-names.json#L12:8
      definitions/Foo/properties/p1
        at file:///home/mharder/openapi-diff-mh/incompat-prop/src/test/specs/incompatible-properties/duplicate-names.json#L25:8

Test case: https://github.com/Azure/openapi-diff/pull/481

Reason, it assumes model names are unique across all files:

https://github.com/Azure/openapi-diff/blob/bb4653d32f49ceb2abab48656c42c253865697e1/src/lib/util/resolveSwagger.ts#L346-L352

Related: #347

Dominant language: C#
Stars: 290
Forks: 50
Avg merge: 2d 21h
Merged PRs (30d): 10

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Add more to the documentation Open

:watch: Not Triaged dotnet-fsharp/svc

Difficulty 1/5 Under an hour Newbie friendliness 90/100

dotnet/docs#56209 · Opened Sep 22, 2026
WebPubSubServiceClient.GetClientAccessUri (sync) drops the groups argument on the TokenCredential path Open

Client customer-reported needs-team-attention question Service Attention WebPubSub

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

Azure/azure-sdk-for-net#63292 · 3 comments · 1 reaction · Opened Sep 22, 2026
Add support for WebRequestMethod QUERY Open

Issue-Enhancement Needs-Triage

Difficulty 1/5 Under an hour Newbie friendliness 86/100

PowerShell/PowerShell#28061 · 2 reactions · Opened Sep 22, 2026
Update Microsoft.Identity.Web dependency Open

dependencies needs-team-triage server-Azure.Mcp

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

microsoft/mcp#3752 · 1 comment · Opened Sep 22, 2026
Drop INCLUDES versioning from SignalR Hubs article Open

aspnet-core/svc aspnetcore-signalr/subsvc doc-enhancement Pri2 SignalR

Difficulty 1/5 Under an hour Newbie friendliness 88/100

dotnet/AspNetCore.Docs#37729 · Opened Sep 22, 2026

More C# issues